-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE] Adding website structure #7
Conversation
058a847
to
4d06240
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I don't have much to say excepting thank you !
I still have some questions 👼 :
- regarding the script, why not implementing them in golang ? Could be easier no ?
- regarding the font in the vendor, isn't possible to download it with npm ?
- regarding the Perses logo, isn't possible to use the SVG instead of having multiple different size version of it ?
"@hyas/doks-core": "^1.1.1" | ||
}, | ||
"engines": { | ||
"node": ">=16.12.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we use the v18 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say yes, but I'll test 😄
website/netlify.toml
Outdated
@@ -0,0 +1,48 @@ | |||
[build] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you still want to use netlify to build and deploy the website ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, I'll delete it.
website/layouts/index.html
Outdated
<!-- <div class="col-lg-5"> | ||
<h2 class="h4">Read the docs</h2> | ||
<p>Learn more in the <a href="https://getdoks.org/">Docs</a>.</p> | ||
</div> --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe you want to clean that section
My pleasure mate help always I can 😄
The shell works fine, but I agree is not the easiest thing to read 😅
I'm not sure, but I'll try
Yes, we can, we just need this one because I didn't find it on the repo, maybe I missed it. |
Signed-off-by: Nicolas Takashi <[email protected]>
4d06240
to
68a067c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice thanks !
This PR I'm adding the website template as well as the automation scripts to build the website content.
I'll open a dedicated PR for the build and publish scripts