Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Adding website structure #7

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

nicolastakashi
Copy link
Contributor

This PR I'm adding the website template as well as the automation scripts to build the website content.
I'll open a dedicated PR for the build and publish scripts

@nicolastakashi nicolastakashi force-pushed the chore/adding-website branch 3 times, most recently from 058a847 to 4d06240 Compare December 14, 2023 17:29
Copy link
Member

@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I don't have much to say excepting thank you !

I still have some questions 👼 :

  • regarding the script, why not implementing them in golang ? Could be easier no ?
  • regarding the font in the vendor, isn't possible to download it with npm ?
  • regarding the Perses logo, isn't possible to use the SVG instead of having multiple different size version of it ?

"@hyas/doks-core": "^1.1.1"
},
"engines": {
"node": ">=16.12.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we use the v18 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say yes, but I'll test 😄

@@ -0,0 +1,48 @@
[build]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you still want to use netlify to build and deploy the website ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, I'll delete it.

<!-- <div class="col-lg-5">
<h2 class="h4">Read the docs</h2>
<p>Learn more in the <a href="https://getdoks.org/">Docs</a>.</p>
</div> -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you want to clean that section

@nicolastakashi
Copy link
Contributor Author

Overall I don't have much to say except thank you !

I still have some questions 👼 :

  • regarding the script, why not implement them in golang? It could be easier no?
  • regarding the font in the vendor, isn't it possible to download it with npm?
  • regarding the Perses logo, isn't it possible to use the SVG instead of having multiple different size versions of it ?

My pleasure mate help always I can 😄
Regarding your questions.

  • regarding the script, why not implement it in Golang? It could be easier no?
    I'm a bit torn, I mean use go lang and execute shell commands from there I don't see many values, we could easily git client but I guess it will require more effort and I'm not sure about mdox if we could easily invoke it from golang without using any cmd.run.

The shell works fine, but I agree is not the easiest thing to read 😅
If you're ok with the shell I'm too.

  • regarding the font in the vendor, isn't it possible to download it with npm?

I'm not sure, but I'll try
I'm currently using the docks template as it is, and in the mainstream, the fonts are available on the repo.

  • regarding the Perses logo, isn't it possible to use the SVG instead of having multiple different size versions of it ?

Yes, we can, we just need this one because I didn't find it on the repo, maybe I missed it.

Signed-off-by: Nicolas Takashi <[email protected]>
Copy link
Member

@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks !

@Nexucis Nexucis merged commit 0bd5e76 into perses:main Dec 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants